[cherrypick-0.18] move manifest image references to ghcr (#2529) #2535
Conversation
* move to ghcr Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com> * move images to ghcr Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com> * manifests Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com> * change registry in all path Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com> * update script Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com> * fix Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com> * fix Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com> * slight fix Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com> --------- Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com> Signed-off-by: Mahdi Khashan <58775404+mahdikhashan@users.noreply.github.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
saileshd1402
changed the title
There was a problem hiding this comment.
I think, we should be good to merge it.
The release script should override the latest tag to the correct release tag:
https://github.com/kubeflow/katib/blob/master/scripts/v1beta1/update-images.sh#L76-L79
/lgtm
/assign @johnugeorge @tenzen-y @Electronic-Waste
| @@ -232,7 +232,7 @@ | |||
| " \"containers\": [\n", | |||
| " {\n", | |||
| " \"name\": \"training-container\",\n", | |||
| " \"image\": \"docker.io/kubeflowkatib/darts-cnn-cifar10:v0.13.0\",\n", | |||
| " \"image\": \"ghcr.io/kubeflow/katib/darts-cnn-cifar10:v0.13.0\",\n", | |||
There was a problem hiding this comment.
looks like some notebook examples will break. we should create and issue for it
There was a problem hiding this comment.
Yes, we might want to rollback changes in these Notebook to use image from the DockerHub for now.
Do you want to do that in this cherry-pick PR and then fix it in the master branch?
- https://github.com/kubeflow/katib/blob/1ef5048b33adab342c84695429e1263db2534c5f/examples/v1beta1/kubeflow-pipelines/early-stopping.ipynb
- https://github.com/kubeflow/katib/blob/1ef5048b33adab342c84695429e1263db2534c5f/examples/v1beta1/sdk/nas-with-darts.ipynb
- https://github.com/kubeflow/katib/blob/1ef5048b33adab342c84695429e1263db2534c5f/examples/v1beta1/sdk/cmaes-and-resume-policies.ipynb
Signed-off-by: sailesh duddupudi <saileshradar@gmail.com>
saileshd1402
force-pushed
the
cherry-pick-db4b68bf
branch
from
6a7fb77 to
bd0150e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
move to ghcr
move images to ghcr
manifests
change registry in all path
update script
fix
fix
slight fix
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Checklist: