Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci setup #22

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Ci setup #22

merged 1 commit into from
Apr 9, 2018

Conversation

YujiOshima
Copy link
Contributor

@YujiOshima YujiOshima commented Apr 9, 2018

I added test codes and argo files.
For Now, only components test and deploy Katib components on k8s. No e2e test.
Tests are defined in test/script dir.
See also kubernetes/test-infra#7541

/assign @gaocegege
cc @jlewi

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
@gaocegege
Copy link
Member

LGTM

@jlewi Do you want to have another review?

@gaocegege
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

@jlewi Hi, do you have any idea about why the ci bot does not auto merge the PR? 🤔 I am not really familiar about the process about bot.

@gaocegege gaocegege merged commit 830e2a7 into kubeflow:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants