UI: Fix unit tests

[elenzio9]

This PR fixes the Katib unit tests. In order to run the unit tests, try:

• npm i to install the updated packages and after
• npm run test to run the tests

Related PRs: kubeflow/kubeflow#6676, #1974 (review)

Signed-off-by: Elena Zioga elena@arrikto.com

[kimwnasptd]

@johnugeorge @tenzen-y I see in the steps of the GH actions the following log

Requested labels: ubuntu-latest
Job defined at: kubeflow/katib/.github/workflows/test-go.yaml@refs/pull/1977/merge
Waiting for a runner to pick up this job...

Do you have any idea what this is?

I'll also assign myself for reviewing this one as well
/assign @kimwnasptd

[johnugeorge]

Github actions seems to be slow in picking up new runners. Looks like a rate limit. This should be automatically triggered.

[johnugeorge]

There is a formatting issue which is breaking other PRs as well.

https://github.com/kubeflow/katib/actions/runs/3301273112/jobs/5449891807

 Checking formatting...

 src/app/pages/experiment-details/experiment-details.module.ts
 src/app/pages/experiment-details/trials-graph-echarts/trials-graph-echarts.component.html
 src/app/pages/experiment-details/trials-graph-echarts/trials-graph-echarts.component.scss
 src/app/pages/experiment-details/trials-graph-echarts/trials-graph-echarts.module.ts
 Code style issues found in the above file(s). Forgot to run Prettier?

Can you fix this?

@elenzio9 Can you fix it in this PR or a separate PR?

[johnugeorge]

Can you do a code rebase as well?

[kimwnasptd]

I'd propose to have a separate PR just for the formatting, to unblock the rest of the PRs.

@johnugeorge we'll get to it ASAP

[coveralls]

Coverage remained the same at 73.431% when pulling 50c18b1 on arrikto:katib-fix-unit-tests into e444ea9 on kubeflow:master.

[kimwnasptd]

@elenzio9 now that #1979 is merged can you also rebase this branch on top of the latest master and ensure the code is also formatted as expected?

[elenzio9]

@elenzio9 now that #1979 is merged can you also rebase this branch on top of the latest master and ensure the code is also formatted as expected?

I can confirm that the code is formatted. I also rebased the branch.

[kimwnasptd]

@johnugeorge @tenzen-y I see a couple of unrelated tests failing. Do we have to re-run them or is there something else going on?

[johnugeorge]

@kimwnasptd Tests passed

[kimwnasptd]

I tried out the PR locally and can confirm it all tests pass with npm run test.

Next up we'll take a look at updating the GH Action for the frontend to automatically run these tests for each PR https://github.com/kubeflow/katib/blob/master/.github/workflows/test-node.yaml

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elenzio9, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/new-ui/v1beta1/OWNERS [kimwnasptd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment