Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifests: Upgrade cert-manager API from v1alpha2 to v1 #1752

Merged
merged 1 commit into from
Jan 11, 2022
Merged

manifests: Upgrade cert-manager API from v1alpha2 to v1 #1752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions manifests/v1beta1/installs/katib-cert-manager/certificate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: cert-manager.io/v1alpha2
apiVersion: cert-manager.io/v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it require any additional API changes after switching from v1alpha2 to v1 ?

cc @yanniszark @kimwnasptd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using cert-manager v1.3 in the manifests repo.

The cert-manager deprecated the following cert-manager APIs from v1.4

cert-manager.io/v1alpha2
cert-manager.io/v1alpha3
cert-manager.io/v1beta1
acme.cert-manager.io/v1alpha2
acme.cert-manager.io/v1alpha3
acme.cert-manager.io/v1beta1

https://cert-manager.io/docs/release-notes/release-notes-1.4/

And the latest cert-manager only supports v1 now.

kind: Certificate
metadata:
name: katib-webhook-cert
Expand All @@ -13,7 +13,7 @@ spec:
name: katib-selfsigned-issuer
secretName: katib-webhook-cert
---
apiVersion: cert-manager.io/v1alpha2
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
name: katib-selfsigned-issuer
Expand Down
2 changes: 1 addition & 1 deletion manifests/v1beta1/installs/katib-cert-manager/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ vars:
objref:
kind: Certificate
group: cert-manager.io
version: v1alpha2
version: v1
name: katib-webhook-cert
fieldref:
fieldpath: metadata.name
Expand Down