Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trial images build to the CI #1457

Merged
merged 10 commits into from
Mar 10, 2021
Merged

Add Trial images build to the CI #1457

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bb45bed
Fix image for MXNET mnist
andreyvelich Mar 8, 2021
509278e
Add build process for Katib Trial template in the CI
andreyvelich Mar 8, 2021
4135314
Change release registry to kubeflowkatib
andreyvelich Mar 8, 2021
a2a58ff
Few changes
andreyvelich Mar 8, 2021
a80324d
Simplify sed for mnist
andreyvelich Mar 9, 2021
b5b006f
Add script to change trial images
andreyvelich Mar 9, 2021
b7f4392
Modify script
andreyvelich Mar 9, 2021
84f6021
Add if for macos
andreyvelich Mar 9, 2021
26377de
Enable PyTorch examples
andreyvelich Mar 9, 2021
3a851e7
Remove test print
andreyvelich Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Modify script
  • Loading branch information
@andreyvelich
andreyvelich committed Mar 9, 2021
commit b7f43924a36cfa8793ef62a45dc88c4f8e72f8c1
2 changes: 1 addition & 1 deletion examples/v1beta1/custom-metricscollector-example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ spec:
containers:
- name: training-container
# TODO (andreyvelich): Add tag to the image.
image: docker.io/kubeflowkatib/pytorch-mnist
image: docker.io/kubeflowkatib/pytorch-mnist:latest
imagePullPolicy: Always
command:
- "python3"
Expand Down
2 changes: 1 addition & 1 deletion examples/v1beta1/file-metricscollector-example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ spec:
containers:
- name: training-container
# TODO (andreyvelich): Add tag to the image.
image: docker.io/kubeflowkatib/pytorch-mnist
image: docker.io/kubeflowkatib/pytorch-mnist:latest
imagePullPolicy: Always
command:
- "python3"
Expand Down
4 changes: 2 additions & 2 deletions examples/v1beta1/pytorchjob-example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ spec:
containers:
- name: pytorch
# TODO (andreyvelich): Add tag to the image.
image: docker.io/kubeflowkatib/pytorch-mnist
image: docker.io/kubeflowkatib/pytorch-mnist:latest
imagePullPolicy: Always
command:
- "python3"
Expand All @@ -62,7 +62,7 @@ spec:
containers:
- name: pytorch
# TODO (andreyvelich): Add tag to the image.
image: docker.io/kubeflowkatib/pytorch-mnist
image: docker.io/kubeflowkatib/pytorch-mnist:latest
imagePullPolicy: Always
command:
- "python3"
Expand Down
4 changes: 2 additions & 2 deletions manifests/v1beta1/components/katib-controller/trial-template-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ data:
containers:
- name: pytorch
# TODO (andreyvelich): Add tag to the image.
image: docker.io/kubeflowkatib/pytorch-mnist
image: docker.io/kubeflowkatib/pytorch-mnist:latest
imagePullPolicy: Always
command:
- "python3"
Expand All @@ -69,7 +69,7 @@ data:
containers:
- name: pytorch
# TODO (andreyvelich): Add tag to the image.
image: docker.io/kubeflowkatib/pytorch-mnist
image: docker.io/kubeflowkatib/pytorch-mnist:latest
imagePullPolicy: Always
command:
- "python3"
Expand Down
4 changes: 2 additions & 2 deletions manifests/v1beta1/katib-controller/trial-template-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ data:
containers:
- name: pytorch
# TODO (andreyvelich): Add tag to the image.
image: docker.io/kubeflowkatib/pytorch-mnist
image: docker.io/kubeflowkatib/pytorch-mnist:latest
imagePullPolicy: Always
command:
- "python3"
Expand All @@ -70,7 +70,7 @@ data:
containers:
- name: pytorch
# TODO (andreyvelich): Add tag to the image.
image: docker.io/kubeflowkatib/pytorch-mnist
image: docker.io/kubeflowkatib/pytorch-mnist:latest
imagePullPolicy: Always
command:
- "python3"
Expand Down
4 changes: 2 additions & 2 deletions operators/katib-controller/files/pytorchJobTemplate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ spec:
containers:
- name: pytorch
# TODO (andreyvelich): Add tag to the image.
image: docker.io/kubeflowkatib/pytorch-mnist
image: docker.io/kubeflowkatib/pytorch-mnist:latest
imagePullPolicy: Always
command:
- "python3"
Expand All @@ -26,7 +26,7 @@ spec:
containers:
- name: pytorch
# TODO (andreyvelich): Add tag to the image.
image: docker.io/kubeflowkatib/pytorch-mnist
image: docker.io/kubeflowkatib/pytorch-mnist:latest
imagePullPolicy: Always
command:
- "python3"
Expand Down
2 changes: 0 additions & 2 deletions scripts/v1beta1/update-trial-images.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ echo "Updating Trial template images..."
echo "Image prefix: ${IMAGE_PREFIX}"
echo "Image tag: ${TAG}"

exit 1

# Base prefix for the Trial template images.
BASE_IMAGE_PREFIX="docker.io/kubeflowkatib/"

Expand Down