Support volume settings in Katib config #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andreyvelich
force-pushed
the
from-volume-config-settings
branch
from
73aabcb to
0ebbd06
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added possibilities to set PVC and PV specification from Katib config.
By default PVC uses
katib-suggestionstorage class name.If PVC is created with this StorageClass, controller also deploys PV for the suggestion with settings from Katib config.
User can change
HostPath, but ifHostPathis/tmp/katib/suggestions/we added:/tmp/katib/suggestions/<suggestion-name>-<suggestion-algorithm>-<suggestion-namespace>to theHostPath./assign @johnugeorge @gaocegege @sperlingxx