Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic jobProvider and suggestionComposer registration #1069

Merged
merged 10 commits into from
Feb 28, 2020
Merged

dynamic jobProvider and suggestionComposer registration #1069

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e6c3475
dynamic jobProvider and suggestionComposer registration
sperlingxx Feb 25, 2020
a638353
enforce gofmt
sperlingxx Feb 26, 2020
39c4184
fix ut
sperlingxx Feb 26, 2020
0dfea24
fix ut
sperlingxx Feb 26, 2020
f559b32
fix gofmt
sperlingxx Feb 26, 2020
35929d2
fix
sperlingxx Feb 26, 2020
e4d2988
refine imports
sperlingxx Feb 26, 2020
4180f11
contain providers into package(v1alpha3)
sperlingxx Feb 27, 2020
35ea96e
move job kubeflow into where providerBase in
sperlingxx Feb 27, 2020
919cdb5
add consts
sperlingxx Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@sperlingxx
sperlingxx committed Feb 26, 2020
commit 35929d281a9e5a32202434e0528984638fb3ea72
2 changes: 1 addition & 1 deletion pkg/controller.v1alpha3/suggestion/suggestion_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func newReconciler(mgr manager.Manager) reconcile.Reconciler {
Client: mgr.GetClient(),
SuggestionClient: suggestionclient.New(),
scheme: mgr.GetScheme(),
Composer: composer.New(mgr.GetScheme(), mgr.GetClient()),
Composer: composer.New(mgr),
recorder: mgr.GetRecorder(ControllerName),
}
}
Expand Down