Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

add jinchihe as approver #41

Merged
merged 1 commit into from
May 16, 2019
Merged

Conversation

jinchihe
Copy link
Member

@jinchihe jinchihe commented May 15, 2019

Provide some PRs before and be already a reviewer.
Add jinchihe as approver to better contribution. Thanks a lot!


This change is Reviewable

@ryandawsonuk
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link

@ryandawsonuk: changing LGTM is restricted to assignees, and only kubeflow/example-seldon repo collaborators may be assigned issues.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ukclivecox
Copy link
Contributor

/assign @ryandawsonuk

@k8s-ci-robot
Copy link

@cliveseldon: GitHub didn't allow me to assign the following users: ryandawsonuk.

Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @ryandawsonuk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jinchihe
Copy link
Member Author

Seems that's caused by ryandawsonuk is not kubeflow members?

/assign @cliveseldon

@ukclivecox
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon, ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 979a351 into kubeflow:master May 16, 2019
@jinchihe jinchihe deleted the update_owner branch May 16, 2019 08:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants