Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Provide notebook pip requirements and default kubeflow version in example env #39

Merged
merged 2 commits into from
May 16, 2019
Merged

Provide notebook pip requirements and default kubeflow version in example env #39

merged 2 commits into from
May 16, 2019

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented May 15, 2019

This change is Reviewable

@jinchihe
Copy link
Member

/lgtm

@jinchihe
Copy link
Member

/approve

@jinchihe
Copy link
Member

Oh...Sorry, seems I have not fully approve permission.

/approve cancel

@ryandawsonuk
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link

@ryandawsonuk: changing LGTM is restricted to assignees, and only kubeflow/example-seldon repo collaborators may be assigned issues.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ryandawsonuk
Copy link
Contributor

/assign @jinchihe

@jinchihe
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jinchihe, ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 00c903c into kubeflow:master May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants