-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for additional chart labels in values #3676
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mittal-ishaan
commented
Sep 20, 2024
@mittal-ishaan Could you provide example output of how you templated the Helm chart successfully here? Additionally, could you link the associated Jira for this work? |
thomasvn
reviewed
Sep 20, 2024
thomasvn
reviewed
Sep 20, 2024
Looks like a minor improvement here is to do some new line stripping under |
added a |
This looks good to me! I've also tested by doing the following. chartLabels:
thomasnTest: "helloworld" helm template cost-analyzer --debug -f values-chartLabels.yaml | grep -C 3 thomasnTest
labels:
helm.sh/chart: cost-analyzer-2.3.3
app.kubernetes.io/managed-by: Helm
thomasnTest: helloworld
app.kubernetes.io/name: cost-analyzer
app.kubernetes.io/instance: release-name
app: cost-analyzer
--
labels:
helm.sh/chart: cost-analyzer-2.3.3
app.kubernetes.io/managed-by: Helm
thomasnTest: helloworld
app: aggregator
spec:
selector:
--
labels:
helm.sh/chart: cost-analyzer-2.3.3
app.kubernetes.io/managed-by: Helm
thomasnTest: helloworld
app.kubernetes.io/name: forecasting
app.kubernetes.io/instance: release-name
app: forecasting
--
labels:
helm.sh/chart: cost-analyzer-2.3.3
app.kubernetes.io/managed-by: Helm
thomasnTest: helloworld
app.kubernetes.io/name: forecasting
app.kubernetes.io/instance: release-name
app: forecasting |
thomasvn
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Allow users to add additional chart labels through values.yaml
Does this PR rely on any other PRs?
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Users will now be able to add additional chart labels through values
Links to Issues or tickets this PR addresses or fixes
https://kubecost.atlassian.net/browse/ENG-2368
What risks are associated with merging this PR? What is required to fully test this PR?
low risk as this will be empty object by default and will be only adding chart labels when defined by user.
How was this PR tested?
rendered the helm chart template locally with and without additional chart labels
Ran the command
template.yaml had the following result for one of the manifest
Have you made an update to documentation? If so, please provide the corresponding PR.
NA