Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Bump/add cluster versions #3510

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Conversation

chipzoller
Copy link
Collaborator

@chipzoller chipzoller commented Jun 24, 2024

Signed-off-by: chipzoller chipzoller@gmail.com

What does this PR change?

  • Adds EKS v1.30 to the test matrix and forces the gp2 StorageClass for all EKS installations.
  • Updates all KinD minor versions to latest patch image
  • Adds 1.30 to KinD test matrix
  • Adds OKD 4.15 to test matrix

Does this PR rely on any other PRs?

No

How does this PR impact users? (This is the kind of thing that goes in release notes!)

None, CI only.

Links to Issues or tickets this PR addresses or fixes

Closes #3493

What risks are associated with merging this PR? What is required to fully test this PR?

None, CI only.

How was this PR tested?

Will be tested manually after PR is merged. Testing of this change will not be reflected in the Actions run as part of this PR (known limitation).

Have you made an update to documentation? If so, please provide the corresponding PR.

N/A

Signed-off-by: chipzoller <chipzoller@gmail.com>
@chipzoller chipzoller enabled auto-merge June 24, 2024 14:49
@chipzoller chipzoller disabled auto-merge June 24, 2024 14:49
@chipzoller chipzoller enabled auto-merge (squash) June 24, 2024 14:49
@chipzoller
Copy link
Collaborator Author

An open question here: Should we add into the EKS values file the equivalent value to set gp2 as the StorageClass? Pros: it will "just work" for users of EKS 1.30+. Cons: it's a default change which may not work for users who have removed this StorageClass.

Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
@chipzoller chipzoller changed the title [CI] Add EKS 1.30 to test matrix [CI] Bump/add cluster versions Jun 24, 2024
@thomasvn
Copy link
Member

I like the idea of defaulting to a storageClass that "just works" if one is not already defined. As you've mentioned I think it can get quite complicated for existing users if they are already on a different storageClass. Maybe for now it's best to doc as a troubleshooting step?

@chipzoller chipzoller merged commit 30dcd17 into kubecost:develop Jun 24, 2024
15 checks passed
@chipzoller
Copy link
Collaborator Author

I did at least document it here: https://docs.kubecost.com/install-and-configure/install/provider-installations/aws-eks-cost-monitoring#prerequisites-1

@chipzoller chipzoller deleted the cz-eks-130 branch June 24, 2024 17:40
@thomasvn
Copy link
Member

Perfect! I'd be open to attempting a gp2 default. My biggest concern would b that swapping storageClasses may be a destructive operation on some people's PVs? Not 100% sure.

@chipzoller
Copy link
Collaborator Author

Adding a default value sounds good to me. Does that work for you, @jessegoodier ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Add Kubernetes 1.30 to test matrix
2 participants