Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] ignore missing schemas with kubeconform #3076

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

chipzoller
Copy link
Collaborator

@chipzoller chipzoller commented Feb 6, 2024

Signed-off-by: chipzoller chipzoller@gmail.com

What does this PR change?

Sets the -ignore-missing-schemas flag to Kubeconform to allow not checking of CRDs.

Does this PR rely on any other PRs?

Outgoing dependency to #3075

How does this PR impact users? (This is the kind of thing that goes in release notes!)

CI only.

Links to Issues or tickets this PR addresses or fixes

What risks are associated with merging this PR? What is required to fully test this PR?

We may actually need CRD schema checking at some point which won't happen by this change.

How was this PR tested?

Tested in CI.

Have you made an update to documentation? If so, please provide the corresponding PR.

N/A

Signed-off-by: chipzoller <chipzoller@gmail.com>
Copy link
Contributor

@ameijer ameijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Chip, do you have a jira board to track these outstanding follow ups like this 'someday add CRD checking' callout?

@chipzoller chipzoller merged commit 930408e into kubecost:develop Feb 6, 2024
12 checks passed
@chipzoller chipzoller deleted the kubeconform-config branch February 6, 2024 14:18
@chipzoller
Copy link
Collaborator Author

I do not. In this specific case, I don't think it's necessary to log something like this, but in general I would have created a GitHub issue or Jira. I'm still not clear which we prefer. Do you have advice here?

@ameijer
Copy link
Contributor

ameijer commented Feb 6, 2024

Thinking about your specific domain here, I guess I would recommend Jira for a few reasons. Having your own 'helm chart' or 'integrations' Jira board would let you estimate the work, and you would have complete control over the ordered backlog, which you don't have here since this is a public issue stream. Even if you aren't doing sprints or biting down the backlog yourself, if it is already in jira, it can get moved over to another teams sprint when it is decided that does need to get built. Just my 0.02

@chipzoller
Copy link
Collaborator Author

Haven't forgot about this and appreciate the feedback. My concern is creating something that no one else sees and/or cares about other than me. I will check with Thomas and folks to see what path they'd suggest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants