Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix karmor uninstall #382

Merged
merged 2 commits into from
Nov 17, 2023
Merged

fix karmor uninstall #382

merged 2 commits into from
Nov 17, 2023

Conversation

Ankurk99
Copy link
Member

@Ankurk99 Ankurk99 commented Nov 3, 2023 •
edited
Loading

Description

  • Uninstall KubeArmor Daemonset
  • Uninstall all the resources based on label (kubearmor-app)
  • karmor uninstall resources uninstall it from all the ns and
  • karmor uninstall -n <ns> uninstalls the resources from that particular ns
  • fixed the rotating status cursor issue on terminal resize

@Ankurk99 Ankurk99 marked this pull request as ready for review November 6, 2023 04:51
daemon1024
daemon1024 requested changes Nov 6, 2023
View reviewed changes
install/install.go Outdated Show resolved Hide resolved
@Ankurk99 Ankurk99 marked this pull request as draft November 14, 2023 05:42
@Ankurk99 Ankurk99 force-pushed the fix-uninstall branch 3 times, most recently from ede094c to eb424e7 Compare November 16, 2023 05:00
@Ankurk99 Ankurk99 marked this pull request as ready for review November 16, 2023 05:02
@Ankurk99 Ankurk99 force-pushed the fix-uninstall branch 2 times, most recently from 95c5230 to 5cf210f Compare November 17, 2023 01:53
daemon1024
daemon1024 requested changes Nov 17, 2023
View reviewed changes
Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, tried it out locally. Works as intended. LGTM 🙌🏽

install/install.go Outdated Show resolved Hide resolved
@Ankurk99
fix karmor uninstall
800a93d 
Signed-off-by: Ankur Kothiwal <ankur.kothiwal99@gmail.com>
@Ankurk99
update go version to v1.21
fffae68 
Signed-off-by: Ankur Kothiwal <ankur.kothiwal99@gmail.com>
DelusionalOptimist
DelusionalOptimist approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@DelusionalOptimist DelusionalOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @Ankurk99. 🚀

@Ankurk99 Ankurk99 merged commit 7b409be into kubearmor:main Nov 17, 2023
10 checks passed
@Ankurk99 Ankurk99 deleted the fix-uninstall branch November 17, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DelusionalOptimist DelusionalOptimist DelusionalOptimist approved these changes

@daemon1024 daemon1024 daemon1024 approved these changes

@Aryan-sharma11 Aryan-sharma11 Awaiting requested review from Aryan-sharma11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ankurk99 @daemon1024 @DelusionalOptimist