-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load kubeconfig filepath when load rest config fail #1201
Conversation
What is the purpose of this modification? |
kubean/cmd/kubean-admission/app/app.go Lines 51 to 63 in cb4c77f
Because this is code logic error, when first err not nil, below code will never be executed! kubean/cmd/kubean-admission/app/app.go Line 59 in cb4c77f
same logic you can reference to this code: kubean/cmd/kubean-operator/app/app.go Lines 104 to 110 in cb4c77f
|
And then
I don't know why we use it this way, like this code: kubean/cmd/kubean-admission/app/app.go Line 59 in cb4c77f
kubean/cmd/kubean-operator/app/app.go Line 106 in cb4c77f
|
😀 I think it is possible to consider commenting out the |
I also think it should be like this. I will fix it. |
Please review again, thanks! @ErikJiang |
Please troubleshoot the CI problem: |
Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix(kubean-admission):load kubeconfig filepath when load rest config fail
Which issue(s) this PR fixes:
None