Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1675
I found 3 different ways of doing this, but I'm not sure which one is the best.
This PR implements Option 1, but I'm fine with other options too (except maybe 3, my least favorite)
identity_pem
during themake_generic_builder
and pass that onto both rustls and openssl HttpsConnector functions as an arg. This is a breaking change for those who are NOT using themake_generic_builder
function.exec_identity_pem
call in both rustls and openssl connector builder as an arg, and bubble up the expiration datetime to themake_generic_builder
function. This is also a breaking change for those who are using themake_generic_builder
function as the return type for the HttpsConnector functions will change.exec_identity_pem
twice, once in themake_generic_builder
function just to get the expiration date, and again inside the rustls and openssl HttpsConnector functions (as it is currently). This is NOT a breaking change, but it is inefficient as we are calling theexec_identity_pem
function twice as this is a blocking system call.