Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add valid_until to Client #1676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

goenning
Copy link
Contributor

@goenning goenning commented Jan 2, 2025

fixes #1675

I found 3 different ways of doing this, but I'm not sure which one is the best.

This PR implements Option 1, but I'm fine with other options too (except maybe 3, my least favorite)

  • Option 1: Fetch the identity_pem during the make_generic_builder and pass that onto both rustls and openssl HttpsConnector functions as an arg. This is a breaking change for those who are NOT using the make_generic_builder function.
  • Option 2: Keep the exec_identity_pem call in both rustls and openssl connector builder as an arg, and bubble up the expiration datetime to the make_generic_builder function. This is also a breaking change for those who are using the make_generic_builder function as the return type for the HttpsConnector functions will change.
  • Option 3: Call exec_identity_pem twice, once in the make_generic_builder function just to get the expiration date, and again inside the rustls and openssl HttpsConnector functions (as it is currently). This is NOT a breaking change, but it is inefficient as we are calling the exec_identity_pem function twice as this is a blocking system call.

Signed-off-by: goenning <me@goenning.net>
@goenning
Copy link
Contributor Author

goenning commented Jan 2, 2025

will work on fixing tests soon, just wanted to get your thoughts on the options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kube ignores expirationTimestamp when exec returns a client certificate
1 participant