Always rustify member names #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clux
force-pushed
the
always-rustify-names
branch
from
25bc38b
to
83ac3e9
Compare
|
cc @felipesere |
Breaking change to make variables always follow rust conventions. This avoids a number of problems: - the need to omit an inner attribute in a generated file to allow non_snake_cased vars (see #69) - unhelpful crashes because of non-rust conventioned keys (see #81) And as a result we get to remove two options that generally had a "correct choice" - --rust-case or -z (now implied default) so option removed - --hide-inner-attr or -i only mattered if you didn't use -z so removed Signed-off-by: clux <sszynrae@gmail.com>
clux
force-pushed
the
always-rustify-names
branch
from
83ac3e9
to
2eafa93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change to make variables always follow rust conventions.
This avoids a number of problems:
non_snake_cased vars (see Enum members need to be PascalCased #69)
And as a result we get to remove two options that generally had a
"correct choice"
--rust-caseor-z(now implied default) so option removed--hide-inner-attror-ionly mattered if you didn't use-zso removedThus the generated case for crds now always follow the standard rust convention:
structmembers usesnake_caseenummembers usePascalCase(and this is a safe rename because we knew the original name so we just emit a serde(rename) attr to ensure serialization uses the correct keys)