Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clap to v3 #72

Merged
merged 2 commits into from
May 25, 2022
Merged

Update clap to v3 #72

merged 2 commits into from
May 25, 2022

Conversation

imp
Copy link
Collaborator

@imp imp commented May 25, 2022

Now that clapv3 is stable it makes sense to update.

Also as a separate commit small clippy cleanup

imp added 2 commits May 25, 2022 16:42
@imp
clippy::needless_borrow
af71029 
Signed-off-by: Cyril Plisko <cyril.plisko@mountall.com>
@imp
Update to clapv3
6b1efd1 
Signed-off-by: Cyril Plisko <cyril.plisko@mountall.com>
clux
clux approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. Was hoping we could go in this direction!

@clux clux merged commit 8b96b6a into kube-rs:main May 25, 2022
@imp imp deleted the clapv3 branch May 25, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clux clux clux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imp @clux