Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for enum renames and refactor analyzer interface #71

Merged
merged 5 commits into from
May 3, 2022
Merged

Add support for enum renames and refactor analyzer interface #71

merged 5 commits into from
May 3, 2022

Conversation

clux
Copy link
Member

@clux clux commented May 3, 2022

Creates an Output struct wrapper, a simpler analyze fn deferring to the internal analyze_ recursive fn.

Creates rename method on Output to do all renaming there and add serde annotations. Required merging #63.
Could then move KEYWORDS into lib.rs and all heck imports to new output.rs.

clux added 3 commits May 3, 2022 08:01
@clux
Simpler analyze entry-point for tests and main
eace6ac 
for #70

Signed-off-by: clux <sszynrae@gmail.com>
@clux
refactor struct renames and fix enum naming
406576c 
Signed-off-by: clux <sszynrae@gmail.com>
@clux
rename outputs to something more appropriate
c6639dc 
outputstruct can be an enum now, so rename to container

containers contain members, and a new Output wrapper contains all
containers.

does main refactoring in #70

Signed-off-by: clux <sszynrae@gmail.com>
This was linked to issues May 3, 2022
Enum members need to be PascalCased #69
Closed
Simplify interfaces and restructure logic #70
Closed
clux added 2 commits May 3, 2022 08:47
@clux
update --all
726664e 
Signed-off-by: clux <sszynrae@gmail.com>
@clux
factor out builders into Output::builder_fields
68203ce 
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux merged commit 8d53bdb into main May 3, 2022
@clux clux deleted the refactor branch May 3, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify interfaces and restructure logic Enum members need to be PascalCased
1 participant
@clux