Continue docstring after newline #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antifuchs
force-pushed
the
newline-in-docs
branch
from
7964b0b
to
3e4220c
Compare
|
Updated! |
clux
approved these changes
Feb 25, 2022
|
Thanks a lot. Before I can merge, are you able to |
This uses the cert-manager 1.7.1 CRDs and is the only test that uses --docs, so far. Signed-off-by: Andreas Fuchs <asf@materialize.com>
If the documentation of a resource includes newlines, we must add a new /// marker after that newline, otherwise the code generation yields a syntax error. This is pretty naive, but effective: The docs that are generated are correctly indented and result in files that compile. Signed-off-by: Andreas Fuchs <asf@materialize.com>
antifuchs
force-pushed
the
newline-in-docs
branch
from
3e4220c
to
528dc72
Compare
|
Re-done with sign-off! |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #35 and adds a test to ensure that it is/stays fixed (-: