Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set status explicitly in the kube tag #34

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Set status explicitly in the kube tag #34

merged 1 commit into from
Feb 16, 2022

Conversation

flaper87
Copy link
Contributor

Without this, the status data won't be accessible through the generated struct

fixes #4

Signed-off-by: Flavio Percoco flaper87@gmail.com

src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
@flaper87
Copy link
Contributor Author

@clux let's get #33 in first and then we can test this one on top of that one :D

@clux
Copy link
Member

clux commented Feb 16, 2022

Yeah, good plan. We probably need to do some changes afterwards as well to get the status object patched in (kubectl doesn't apply statuses - so currently no way to verify the instance you sent)

@clux
Copy link
Member

clux commented Feb 16, 2022

main is updated if you want to update

@flaper87
Copy link
Contributor Author

main is updated if you want to update

done :)

Without this, the status data won't be accessible through the generated struct

fixes kube-rs#4

Signed-off-by: Flavio Percoco <flaper87@gmail.com>
@flaper87 flaper87 requested a review from clux February 16, 2022 16:25
);
if scope == "Namespaced" {
println!(r#"#[kube(namespaced)]"#);
}

if let Some(CustomResourceSubresources { status: Some(_), .. }) = version.subresources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah that is a nice pattern match 👍

@clux
Copy link
Member

clux commented Feb 16, 2022

thanks a lot - tests are passing :-)

@clux clux merged commit 1132bf4 into kube-rs:main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handle status
2 participants