Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support unknown integer & number formats #223

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Conversation

sebhoss
Copy link
Contributor

@sebhoss sebhoss commented Apr 6, 2024

https://github.com/kyverno/chainsaw/blob/main/.crds/chainsaw.kyverno.io_configurations.yaml uses a type: integer with format: int which is currently not supported in kopium. According to the openapi spec, tools that do not recognize a specific format may fallback to the type value alone which is currently mapped to i64 for integers and f64 for numbers. This change brings kopiums behavior in line with the openapi spec and allows such unknown formats to exist in CRDs.

Signed-off-by: Sebastian Hoß <seb@xn--ho-hia.de>
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me. thank you!

@clux clux merged commit b320e73 into kube-rs:main Apr 6, 2024
5 checks passed
@sebhoss sebhoss deleted the int-format branch April 7, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants