-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes clippy lints #105
Fixes clippy lints #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
That was fast :D Added the cache action for clippy as well, since it fetches the cargo index before running |
Yeah, that's helpful. This repo is less professional than kube and could do with some more of this stuff :-) |
You're using the clippy action in kube: - uses: actions-rs/clippy-check@v1
with:
args: "--workspace"
token: ${{ secrets.GITHUB_TOKEN }} Want me to change it here as well? I checked it out before but it looked like it does not work properly for pull requests, but I might be misunderstanding the issue. |
I honestly don't remember what the token is for, but it seems to be required and the action is really nice, and we've not had any problems with it AFAIK. Getting the lints inlined into the PR makes them easy to identify when they are created. |
Signed-off-by: David Herberth <github@dav1d.de>
Updated:
Not sure what that means, but clippy is still executed, so even in the case the action fails clippy runs which is all we need. |
Ah, I guess it only (fully) works (to create inline annotations) if you create a PR from a branch against kube-rs |
Let's try it out :-) |
Fixes clippy lints (except tests) and adds clippy to CI