Bug fix - logging proxy more than one tail for algorunner #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golanha
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Adir111)
golanha
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Reviewable status:
Adir111
deleted the
bug_fix_logging_proxy_more_than_one_tail_for_algorunner
branch
hkube-ci
pushed a commit
that referenced
this pull request
Jan 2, 2025
* fixed bug * test sometimes 27/28 both ok .... bump version [skip ci]
hkube-ci
pushed a commit
that referenced
this pull request
Jan 2, 2025
* fixed bug * test sometimes 27/28 both ok .... bump version [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix in this PR: #2033
The bug caused more than 1 tail to be created on algorunner, when a sideCar tail failed creating (mechanic of re-trying was wrong, if a sideCar failed - both algorunner and sideCar would create a new tail - causing the algorunner to have multiple tails).
This change is