Repository navigation
fix!: potential secret exposure to templating engine and gitops repo history - #681
Merged
Merged
Conversation
…history Signed-off-by: Jan Larwig <jan.larwig@digits.schwarz>
1 of 3 tasks
LSchu
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Breaking change: This PR removes the environment variable map from the template engine scope. As it is a potential security flaw as it can expose secrets to the gitops repository by allowing to template any environment variable contained secret to be templated into arbitrary files.
Change type
Breaking change
Catalogs/Services need to migrate away from hardcoded
.envreferences and instead should fully rely on external-secret references.How I tested it
Notes for reviewers