KeybindingManagerFactory.CreateManager(dataDirectory) shares DI-singleton profiles/commands across directories, leaking one directory's profiles into another's files #114

What's wrong

When a service provider is present, KeybindingManagerFactory.CreateManager(string dataDirectory) (Keybinding/Services/KeybindingManagerFactory.cs:~53-68) resolves the singleton ICommandRegistry and IProfileManager, which are registered as singletons in Extensions/ServiceCollectionExtensions.cs:~43-44. Only the JsonKeybindingRepository is new per directory.

So every manager created for a different directory shares one in-memory set of profiles and commands.

Relatedly, CreateManager() with no arguments returns the DI singleton KeybindingManager, although its doc says "A new KeybindingManager instance".

Failure scenario (reproduced with a temporary MSTest)

var a = factory.CreateManager(dirA);
a.Profiles.CreateProfile("user-a", "User A");
await a.SaveAsync();

var b = factory.CreateManager(dirB);
await b.InitializeAsync();
await b.SaveAsync();

Results:

• b's profiles contain user-a.
• dirB/profiles.json now contains user-a.

An app that keeps per-user or per-workspace keybinding directories gets them cross-contaminated on the first save.

Suggested fix

In CreateManager(dataDirectory), always construct fresh state: new CommandRegistry() and new ProfileManager(), or simply new KeybindingManager(dataDirectory). Resolve from DI only for dependencies that are safe to share. Also either make CreateManager() return a new instance, or correct its doc.

Acceptance: managers created for two different directories don't see each other's profiles, and each directory's profiles.json contains only its own.