Repository navigation
Keep a DockedWindow registered when it is collapsed or tabbed behind another - #601
Merged
Merged
Conversation
…another [patch] Hexa's ImWindow reads any ImGui.Begin returning false as a close and unregisters the window, but Begin also returns false for a collapsed window and for an unselected docked tab. The adapter now vetoes every close except the close button's, which is the only path that clears IsShown. Fixes #600 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GtbgtabvsqUgsTDUDD1xmb
|
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matt · project thread
Before: docking two
DockedWindows into one node as tabs lost the one behind the selected tab for good, and collapsing a floatingDockedWindowdid the same.After: a collapsed or tabbed-behind window stays registered and draws again as soon as it is expanded or its tab is selected. The close button and
Close()still close it.Hexa's
ImWindow.DrawWindowreads anyImGui.Beginreturning false as a close, butBeginalso returns false for a collapsed window and for an unselected docked tab.How: the private
Adapternow overridesOnClosed(ref bool handled)and vetoes the close unlessIsShownis false, which only the close button produces. Three new tests inDockedWindowTests: the tabbed and collapsed cases (both failed before the fix), and a close-button click that still closes (mutation-checked: it fails if the veto is unconditional). The full widget UI suite passes, 708 of 708.Fixes #600
🤖 Generated with Claude Code
https://claude.ai/code/session_01GtbgtabvsqUgsTDUDD1xmb
Generated by Claude Code