Repository navigation
Replace deprecated github_repository attributes in standard.tf #7
Description
Activity
matt-edmondson commented
on Sep 8, 2026 ContributorAuthorMore actionsTriage
Priority: Medium Effort: Small
What needs to be done: Stop passing the deprecated-and-computed
default_branchtogithub_repository(usegithub_branch_defaultif it needs managing), and replace/documenthas_downloadsandvulnerability_alerts.Suggested next steps / acceptance criteria:
- Remove
default_branchfrom the resource args while keeping it inlocal.defaultsformetadata.tf's data-source lookups - Replace or explicitly retain (with a documented reason) the other two deprecated attributes
- Confirm
terraform planproduces no deprecation warnings, or document the remainder
Blockers / dependencies: Should land before .github#3's convergence apply (explicit ordering, author's own comment) to avoid a second pass over 56 repos
Generated by Claude Code
- Remove
matt-edmondson commented
on Sep 22, 2026 ContributorAuthorMore actionsTriage
Not actionable in this repository — same cause as #8. Not assigning myself, nothing branched.
github/standard.tfis not here.maincontains no Terraform at all: the tracked top level is.editorconfig,.github/,.gitignore,.markdownlint.json,CLAUDE.md,DESCRIPTION.md,TAGS.md,docs/,profile/,scripts/— there is nogithub/ormodules/directory, so there is nostandard.tfto edit and no.terraform.lock.hclpinning the provider whose deprecations this issue is about.That matches what #8 established on 2026-09-21 about
docs/superpowers/specs/: the Terraform work lives somewhere outside this repository, most likely the infrastructure repo #4 is about standing up, or a working copy that was never committed.What would unblock this: the same thing that unblocks #8 — say where the Terraform lives, or commit it. Until then #2, #3, #7 and #9 all read as dependents of #4 rather than as independently actionable.
The substance still looks right and is worth keeping:
default_branchbeing deprecated and computed is a real trap, and the issue's note that it must stay inlocal.defaultsformetadata.tf's data sources while not being forwarded to the resource is exactly the kind of detail that gets lost otherwise.
Generated by Claude Code
matt-edmondson commented
on Sep 28, 2026 ContributorAuthorMore actionsDecision (maintainer, 2026-09-28)
Answers the "where does
standard.tflive" question: in the local Terraform branch, which is moving to a new privatektsu-dev/infrastructurerepo (see #4). This issue transfers there once the branch is pushed.The scope and acceptance criteria are unchanged. It still lands before the #3 convergence apply.
Generated by Claude Code
matt-edmondson commented
on Sep 28, 2026 ContributorAuthorMore actions
Context
github/standard.tfsets three attributes that are deprecated ongithub_repositoryinintegrations/github6.13.0, confirmed by reading the provider's published schema:default_branchhas_downloadsvulnerability_alertsDeprecation is a warning rather than an error, so plans and applies still work today. The provider is pinned via a committed
.terraform.lock.hcl, so this will not change under the org without a deliberate upgrade.The one that actually matters
default_branchis deprecated and computed. Setting it on the resource is a no-op. The real mechanism is the separategithub_branch_defaultresource.It still does useful work elsewhere:
github/metadata.tfreadseach.value.default_branchas thebranchargument for thegithub_repository_filedata sources. So it must stay inlocal.defaultsand must not be blindly forwarded to the repository resource.All 56 managed repos are confirmed on
main, so nothing depends on the no-op today.Acceptance criteria
default_branchis not passed togithub_repository, andgithub_branch_defaultis used if the default branch should be managed at allhas_downloadsandvulnerability_alertsare replaced with their current equivalents, or an explicit decision is recorded to keep them until the provider removes themterraform planproduces no deprecation warnings, or the remaining ones are documentedDo this before the convergence apply
Getting it right first avoids a second pass over 56 repositories.