Skip to content

KTOR-9676 Remove a warning when WriteChannelContent is being compress…#5722

Open
Aleksei Tirman (Stexxe) wants to merge 1 commit into
release/3.xfrom
stexxe/compression-stream-warning
Open

KTOR-9676 Remove a warning when WriteChannelContent is being compress…#5722
Aleksei Tirman (Stexxe) wants to merge 1 commit into
release/3.xfrom
stexxe/compression-stream-warning

Conversation

@Stexxe

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 77b49f99-8b36-470f-b0f9-0e25baf950a1

📥 Commits

Reviewing files that changed from the base of the PR and between 5ba9d6f and 198b990.

📒 Files selected for processing (1)
  • ktor-server/ktor-server-plugins/ktor-server-compression/jvm/src/io/ktor/server/plugins/compression/Compression.kt
💤 Files with no reviewable changes (1)
  • ktor-server/ktor-server-plugins/ktor-server-compression/jvm/src/io/ktor/server/plugins/compression/Compression.kt

📝 Walkthrough

Walkthrough

The compression plugin no longer logs a warning when compressing OutgoingContent.WriteChannelContent responses. The body transformation still returns message.compressed(...) unchanged.

Changes

Compression warning removal

Layer / File(s) Summary
Response encoding logging
ktor-server/ktor-server-plugins/ktor-server-compression/jvm/src/io/ktor/server/plugins/compression/Compression.kt
The transformBody branch removes the warning log for OutgoingContent.WriteChannelContent and still proceeds with message.compressed(...).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • bjhham
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No PR description was provided, so the required Subsystem, Motivation, and Solution sections are missing. Add the template sections: Subsystem, Motivation with the KTOR-9676 context, and a brief Solution summary.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the PR's main change: removing the WriteChannelContent compression warning.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stexxe/compression-stream-warning

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants