KTOR-9054 Fix application call coroutine context #5170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bjhham
force-pushed
the
bjhham/routing-call-coroutine-context-fix
branch
3 times, most recently
from
64444e2 to
dc8afa3
Compare
osipxd
approved these changes
Nov 4, 2025
...ver/ktor-server-test-suites/jvm/src/io/ktor/server/testing/suites/SustainabilityTestSuite.kt
Outdated
Show resolved
Hide resolved
…ting/suites/SustainabilityTestSuite.kt Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
bjhham
force-pushed
the
bjhham/routing-call-coroutine-context-fix
branch
from
05ebd83 to
95de419
Compare
bjhham
force-pushed
the
bjhham/routing-call-coroutine-context-fix
branch
from
95de419 to
e19577f
Compare
osipxd
added a commit
that referenced
this pull request
Nov 18, 2025
* KTOR-9054 Fix application call coroutine context * KTOR-9054 Fixup Jetty engine coroutines * Update ktor-server/ktor-server-test-suites/jvm/src/io/ktor/server/testing/suites/SustainabilityTestSuite.kt Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com> * Disable tomcat coroutine hierarchy check --------- Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Server, Netty
Motivation
KTOR-9054 Netty:
applicationandcallcoroutine scopes share the same job instance since 3.3.0Solution
Reverted mistake made in #5070 where I assumed the engine call would follow the job hierarchy and the pipeline context did not, but it is in fact the other way around. It seems the change was not necessary for the auto-reloading fix so it should be fine.
I also included a test to ensure that call coroutine jobs are children of the application job and found this isn't the case all the time, so I fixed the standard Jetty engine and ignored other tests to mitigate impact. Logged a follow up issue KTOR-9058 to fix CIO.