Ktor Client WebRtc kotlin wrappers migration #5021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le and creating extra util functions.
…owser declarations.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
zibet27
force-pushed
the
zibet27/ktor-client-webrtc-kotlin-wrappers-migration
branch
from
a32744f to
c9fe7f7
Compare
…lient-webrtc-kotlin-wrappers-migration
bjhham
approved these changes
Aug 1, 2025
Comment on lines
+38
to
+40
| if (tracks.size > 1) { | ||
| println("Warning: more than one audio track created") | ||
| } |
Contributor
There was a problem hiding this comment.
Would be best to use some logging here over println.
Collaborator
Author
There was a problem hiding this comment.
What kind of logging do you mean?
| throw WebRtcMedia.DeviceException("Failed to create a video track.") | ||
| } | ||
| if (tracks.size > 1) { | ||
| println("Warning: more than one video track created.") |
zibet27
merged commit 5f39fed
into
zibet27/ktor-client-webrtc-android
13 of 18 checks passed
zibet27
deleted the
zibet27/ktor-client-webrtc-kotlin-wrappers-migration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
WebRTC Client
Motivation
Unify the source code for the JS and WASMJS targets.
Solution
kotlin-wrappers-browserpackage to thektor-client-webrtcsubmodule.During the integration, I needed to upgrade the Kotlin version in the branch to
2.2.0because the compiler was failing with aSymbol for Any not foundexception.3.3.0-eapinto this one, so the pull request contains many other commits.kotlin-wrappers, which significantly reduced code size. Moreover, all callbacks now also run in the peer connection's coroutine scope, so we don't lose exceptions thrown there.