KTOR-7202 missing respond file overload #4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacekgajek
changed the title
|
Hey @jacekgajek, could you please change the target branch to |
marychatte
force-pushed
the
jacekgajek/KTOR-7202-Missing-respondFile-overload
branch
from
c7ce492
to
91ee297
Compare
marychatte
force-pushed
the
jacekgajek/KTOR-7202-Missing-respondFile-overload
branch
from
91ee297
to
ddbf476
Compare
marychatte
approved these changes
Sep 11, 2024
|
@osipxd, can you please take a quick look? The PR also contains my changes, and I want them to be reviewed too |
osipxd
reviewed
Sep 11, 2024
ktor-server/ktor-server-core/jvm/src/io/ktor/server/response/ApplicationResponseFunctionsJvm.kt
Outdated
Show resolved
Hide resolved
ktor-server/ktor-server-core/jvm/src/io/ktor/server/response/ApplicationResponseFunctionsJvm.kt
Outdated
Show resolved
Hide resolved
ktor-server/ktor-server-core/jvm/src/io/ktor/server/response/ApplicationResponseFunctionsJvm.kt
Outdated
Show resolved
Hide resolved
ktor-server/ktor-server-core/jvm/src/io/ktor/server/response/ApplicationResponseFunctionsJvm.kt
Outdated
Show resolved
Hide resolved
osipxd
approved these changes
Sep 11, 2024
ktor-server/ktor-server-core/jvm/src/io/ktor/server/response/ApplicationResponseFunctionsJvm.kt
Outdated
Show resolved
Hide resolved
ktor-server/ktor-server-core/jvm/src/io/ktor/server/response/ApplicationResponseFunctionsJvm.kt
Outdated
Show resolved
Hide resolved
…pplicationResponseFunctionsJvm.kt Co-authored-by: Osip Fatkullin <osip.fatkullin@gmail.com>
…-respondFile-overload' into fork/jacekgajek/jacekgajek/KTOR-7202-Missing-respondFile-overload
osipxd
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
ktor-server-core
Motivation
Resolves https://youtrack.jetbrains.com/issue/KTOR-7202/Missing-respondFile-overload
Solution
Add missing overload