Updated inPolygon
#81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The logic for checking whether it crosses the line is fundamentally the same, so I don't think the behavior for numerical accuracy should be better/worse. It's mainly just a shortened version (with the observation that subtracting the booleans should result in the same sign as the cross product if it intersects). Other than that, the main change is that we're using a vector instead of iterators.
|
Collaborator
Author
|
Kattis PointInPolygon submission: https://ideone.com/T4D6qk Couldn't find |
Member
simonlindholm
left a comment
simonlindholm
left a comment
There was a problem hiding this comment.
Looks good, seems like it should be equivalent to the previous version
The note about positive x direction depends on polygon orientation, anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #78 , so review/merge that one first. I'll rebase when that's merged.
This is currently mostly just for keeping track of what I'm working on.