ADD: Support for LANCOM LCOS SX 5 #3670
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noppes
reviewed
May 12, 2025
| super().disable_paging() | ||
| self.clear_buffer() | ||
|
|
||
| def set_terminal_width(self, *args: Any, **kwargs: Any) -> str: |
There was a problem hiding this comment.
There is no need to override the set_terminal_width. It's only ever called from session_preparation which you already override. If you do really want to keep it, you should have it raise NotImplementedError
|
Looking at https://www.lancom-systems.de/fileadmin/download/documentation/CLI-Reference/MA_LCOS-SX-5.20-CLI-Reference_EN.pdf, it says to enter config mode its I also see that you check for |
Noppes
reviewed
May 12, 2025
| offers inconsistent command options | ||
| """ | ||
| self._test_channel_read() | ||
| super().send_command_timing( |
There was a problem hiding this comment.
any reason you are calling send_command for this instead of just using self.enable()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
ADD: Support for LANCOM LCOS SX 5
Description
This PR introduces a new driver for LANCOM devices running LCOS SX 5, which is the OS for the Enterprise models.
Peculiarity
LANCOM does not allow
Execcommands to be run inConfigMode, therefore aconfig-mode-checkis added tosave_configandcleanup.SSH Connection to LCOS SX 5 devices normally start in the
EXECMode. This Mode however offers only inconsistent command usage. Therefore the driver will elevate the Session toprivileged EXECMode by default duringsession_preparationThe
terminal widthcommands dont work on LCOS SX 5Testing
Tested on:
A File with full
showandconfigtest result is attached.2025-05-02_netmiko-lancom-driver-LCOSSX5-test.txt