Skip to content

Commit

Permalink
Fix UI coverage reporting on codecov (pixie-io#1569)
Browse files Browse the repository at this point in the history
Summary: The file sizes and offsets reported for the UI coverage
in codecov were incorrect, this fixes them.

Type of change: /kind cleanup

Test Plan: Ran the coverage build locally and looked at the generated
lcov output.

Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
  • Loading branch information
vihangm authored Jun 24, 2023
1 parent 6321074 commit d65722b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions ci/collect_coverage.sh
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ lcov -r ${COVERAGE_FILE} '**/*_test.go' -o ${COVERAGE_FILE}
lcov -r ${COVERAGE_FILE} '**/*.gen.go' -o ${COVERAGE_FILE}
lcov -r ${COVERAGE_FILE} '**/*-mock.tsx' -o ${COVERAGE_FILE}
lcov -r ${COVERAGE_FILE} '**/*-mock.ts' -o ${COVERAGE_FILE}
lcov -r ${COVERAGE_FILE} 'src/ui/src/types/generated/**' -o ${COVERAGE_FILE}

# Print out the final summary.
lcov --summary ${COVERAGE_FILE}
Expand Down
1 change: 1 addition & 0 deletions src/ui/jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ module.exports = {
...a,
[`^.+\\.${ext}$`]: ['esbuild-jest', {
loader: ext,
sourcemap: true,
target: 'node16',
}]
}), {}),
Expand Down

0 comments on commit d65722b

Please sign in to comment.