Skip to content

Add KDE support for scale factor #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Conversation

precla
Copy link
Contributor

@precla precla commented Jun 19, 2022

As the title says :)

is char (g, k, ... ) ok?

@DamirPorobic
Copy link
Member

Sorry for the delay, I'm currently not getting much time for my open source projects. I think we should use an enum for that with KDE, Gnome and Unknown values. Also, the logic now that I look at it seem to be wrong in this place, we should exract this method into some helper class that can be reused. If you want I can do this change.

@precla
Copy link
Contributor Author

precla commented Jun 27, 2022

Indeed, enum sounds better.
You mean the logic inside getScaleFactor?

@DamirPorobic
Copy link
Member

I mean the logic in getLinuxDesktopEnvironment

@precla
Copy link
Contributor Author

precla commented Jun 28, 2022

i can't wrap my head around making a helper function :D

i'd be glad if you take over :)

@DamirPorobic
Copy link
Member

i'd be glad if you take over :)

Sure, no problem, will do ;)

@DamirPorobic
Copy link
Member

Thanks for provindg the PR! I'll change the enums and the helper class on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants