Skip to content

Commit

Permalink
remove pre-commit from ci
Browse files Browse the repository at this point in the history
  • Loading branch information
c9s committed Jun 21, 2022
1 parent 06de735 commit c4ac2a2
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 15 deletions.
15 changes: 0 additions & 15 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,6 @@ jobs:
restore-keys: |
${{ runner.os }}-go-
- uses: actions/cache@v2
with:
path: |
~/.cache/pip
key: ${{ runner.os }}-pip
restore-keys: |
${{ runner.os }}-pip
- name: Set up MySQL
run: |
sudo /etc/init.d/mysql start
Expand All @@ -56,13 +48,6 @@ jobs:
with:
go-version: 1.18

- name: Run pre-commit
run: |
pip install pre-commit
pre-commit install-hooks
pre-commit run markdownlint --files=README.md --verbose
pre-commit run detect-secrets --all-files --verbose
- name: Install Migration Tool
run: go install github.com/c9s/rockhopper/cmd/rockhopper@v1.2.1

Expand Down
9 changes: 9 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,15 @@ If you find an issue to work on, you are welcome to open a PR with a fix.

### Making Changes

Install pre-commit to check your changes before you commit:

pip install pre-commit
pre-commit install
pre-commit run markdownlint --files=README.md --verbose
pre-commit run detect-secrets --all-files --verbose

See <https://pre-commit.com/> for more details.

For new large features, such as integrating binance futures contracts, please propose a discussion first before you start working on it.

For new small features, you could open a pull request directly.
Expand Down

0 comments on commit c4ac2a2

Please sign in to comment.