Repository navigation
add CI test for Cygwin - #834
jeremyd2019 wants to merge 3 commits into
Conversation
Add cygwin testing
|
I added a cygwin matrix to test 32-bit also (though 32-bit cygwin is no longer supported upstream): https://github.com/jeremyd2019/ksh/actions/runs/13906198215 |
| } | ||
| cygwin_conv_to_win32_path(path, buf); | ||
| return strlen(buf); | ||
| return cygwin_conv_path(CCP_POSIX_TO_WIN_A | CCP_ABSOLUTE, path, buf, siz); |
There was a problem hiding this comment.
Looking back on this now, this is wrong per the specification in the comments above, vs the documentation of cygwin_conv_path.
For cygwin_conv_path, if size is 0, buf may be NULL and it will return the size of buffer required. If size is not 0, it will return 0 on success or -1 on error (error including ENOSPC if size is too small to hold the result).
|
I want the Cygwin updates from this PR, but I don't want the GitHub CI integration for Windows until we can somehow make all the regression tests pass on Cygwin (which is doubtful since Cygwin is so broken in so many ways). I don't want a failing CI run on every ksh commit, it makes us look bad and it makes me feel bad. |
2 participants
Hopefully this can be a start to figure out the issues
@xeiavicaflashrepository @gisburn