forked from Azure/azure-rest-api-specs
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated SDK code for index #4
Draft
luigiw
wants to merge
3
commits into
machinelearningservices-data-plane-poc
Choose a base branch
from
hancwang/autogen2
base: machinelearningservices-data-plane-poc
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigiw
force-pushed
the
hancwang/autogen2
branch
from
February 16, 2024 00:51
ec82d84
to
356f878
Compare
kseager
reviewed
Feb 20, 2024
kseager
force-pushed
the
machinelearningservices-data-plane-poc
branch
5 times, most recently
from
February 29, 2024 23:34
85c155e
to
c3109bc
Compare
kseager
pushed a commit
that referenced
this pull request
May 21, 2024
* Add following operations: - Liveness Session - Person Directory - Person Group - Face List - Face Operations * Restructure and rename operations Omit unreachable types * Change PD to non-LRO * Update example, doc, data decorator and unnecessary sharedRoute * Use union to represent extensible enum Add suppressions Add default value for models Fix age type Rename model in sdk Refine examples and train headers Add uuid type, groupId type and name min length Use our own operation state Change liveness operation to enum Refine group id pattern Use array for csv fields Separate request and response model for collection Flatten interface Flatten parameter for more interface * Mark detect as internal for customization * Add liveness audit response schema * Update documents (add and fix description format and add examples) Co-authored-by: Shawn Lin <Shao.Lin@microsoft.com> * Move path to host template * Move suppression to config Fix format and suppress response code failure Fix breaking changes Switch endpoint to uri Refine liveness session model Move away from standard operation to use our own error code * Set liveness with verify session as internal * Remove 4xx examples for now with some document updates (#4) * Update detection document * Update 4xx examples * Update example parameter and response * Several doc fix for PD * Differenct recognition descriptions for different data structure * Fix bullet points in note and update some PD doc * Update liveness doc * Remove 4xx examples for now to pass validation --------- Co-authored-by: Shawn Lin <Shao.Lin@microsoft.com> Co-authored-by: Shawn Lin <shaoli@microsoft.com> * Add verify image response in create session * Rename API operation name (Azure#5) * Change document to new operation names * Rename * More renaming --------- Co-authored-by: Shawn Lin <Shao.Lin@microsoft.com> Co-authored-by: Shawn Lin <shaoli@microsoft.com> * Refine verify image header description * Add partial update for java * Use shared route for DPG LRO Use original LRO for PD person and face creation * Use resource decorator instead of specify resource in LRO response * Change name for patch to optional * Correct operation status name Correct DPG example * Rename operation status model * Correct operation result example * Add gated attribute * Fix validation * Force public model for internal detect * Correct update DPG model * Disable detect from url convenientAPI for java * Rename dpg write * Fix comment * Rename id and remove customized uuid * Correct access level of landmark and attribute * Correct more models' access * Collect client customization into client.tsp * Correct verify pd parameter type * Correct type * Reorder detect parameters * Rename session model * Refine description for return reco model * Remove detection convenient API * Add link of error code and message (Azure#6) Co-authored-by: Shawn Lin <Shao.Lin@microsoft.com> * Fix validation * Remove unnecessary model * Rename model * Remove redundant line --------- Co-authored-by: Han Chiang <hachiang@microsoft.com> Co-authored-by: shaoli-msft <165001074+shaoli-msft@users.noreply.github.com> Co-authored-by: Shawn Lin <Shao.Lin@microsoft.com> Co-authored-by: Shawn Lin <shaoli@microsoft.com>
kseager
pushed a commit
that referenced
this pull request
May 21, 2024
Address Spec-Reviewer Comments Prompt review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.