Re-add @file:CompilerOpts annotation from 1.2 + bump to 1.4 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the correction. I feel deeply ashamed about my unprofessional approach here. |
holgerbrandl
added a commit
that referenced
this pull request
Mar 27, 2019
|
Haha, no problem. Stuff happens :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some puzzling about what was going wrong in my PR in kscript it appears that you might have forget to push the kscript-annotations:1.2 changes to github after publishing the artefact, which means the 1.3 is missing the changes form 1.2.
It probably would have been an easy fix for you, but in the interest of moving things along, I simply looked at the bytecode of 1.2 and added the annotation again the way it was defined there. I bumped the version to 1.4 assuming you can't update an already published artefact.
I also removed some commented out code as it seemed to be obsolete.