Add authentication arguments to @MavenRepository #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Only minor cosmetic I'll change myself is the pass->password. A few extra characters don't harm here and are more descriptive imho |
holgerbrandl
added a commit
that referenced
this pull request
Mar 6, 2019
|
I've released the updated version to jcenter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Authentication in the @mavenrepository annotation as described in kscripting/kscript#214
I took the liberty of updating the plugin-version to the next logical version after the one referenced in the main plugin: https://github.com/holgerbrandl/kscript/blob/master/src/main/kotlin/kscript/app/Script.kt#L132