Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/search-feature #154

Merged
merged 20 commits into from
Jun 25, 2024
Merged

Feature/search-feature #154

merged 20 commits into from
Jun 25, 2024

Conversation

EtcetFelix
Copy link
Contributor

What does this PR do?

Adds the search feature for the Robots page and the Parts page, including necessary frontend and backend changes.

What issues does this PR fix or reference?

Search Feature

@chennisden
Copy link
Contributor

This is awesome! One thing: could you make it so that the search feature is case insensitive (i.e. 'Robot' matches with 'robot', 'ROBOT', 'rObot', etc)?

@EtcetFelix
Copy link
Contributor Author

Unfortunately, there's 2 problems with this current implementation:

Therefore, I propose merging this PR for now, and opening 2 tasks for the following:
Task 1: Fix db writes to add a new field for searching with case-insensitive queries, and change the dynamo db searches to search on that field
Task 2: Replace all table.scan operations with either a DynamoDB query method with pagination, or query with boto3 (since the AWS boto sdk provides low level pagination abstraction: https://docs.aws.amazon.com/code-library/latest/ug/python_3_dynamodb_code_examples.html#scenarios)

@chennisden
Copy link
Contributor

Bah, unfortunate. I'll open the two issues you have just mentioned and merge the request.

Thanks!

Resolves #154

@chennisden chennisden merged commit 1276119 into kscalelabs:master Jun 25, 2024
1 check passed
@chennisden chennisden mentioned this pull request Jun 25, 2024
2 tasks
@EtcetFelix EtcetFelix deleted the feature/search-feature branch June 25, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants