-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make bmi088 work and other updates #23
Conversation
@harismalik-1 helped a lot with this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small Qs, but if both bno055 and bmi088 work on the zbot, this should be good to go
imu/bmi088/src/lib.rs
Outdated
} | ||
|
||
/// Updates the simple Euler integration state based on gyroscope data. | ||
pub fn update_simple_euler(&mut self, dt: f32) -> Result<(), Error> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How well does this work right now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
surprisingly good, but yes this is a todo to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is removed, and the complimentary filter logic is now in this PR zeroth-robotics/zeroth-bot#93 in for kos-zbot this commit 0badf6d
} | ||
} | ||
|
||
let mut sensor_data = Bmi088Data::default(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to be careful with what we set default data too. E.g. if we fail to read data, what should we put in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe we want to keep the last valid reading and keep track of how old they are? Definitely not a priority, but something to think about for later. How does the bno055 reader implementation handle this rn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm good points, I haven;t thought about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay so just checked and they both have the default value to all zeroes, and they return that if the sensor readings fail I believe. I also think this should be set to the last known values, but low priority I think cause it has never caused an issue so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO for later
ok all the crates have been updated, merging. |
No description provided.