Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit dependency on xesmf #65

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Remove explicit dependency on xesmf #65

merged 1 commit into from
Feb 13, 2024

Conversation

ks905383
Copy link
Owner

xesmf will now only be imported if weights need to be regridded

xesmf is no longer required for installation
esmpy is no longer required for installation

Also added cmocean to list of optional dependencies required for diag_fig()

`xesmf` will now only be imported if weights need to be regridded

`xesmf` is no longer required for installation
`esmpy` is no longer required for installation

Also added `cmocean` to list of optional dependencies required for `diag_fig()`
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0075c7e) 82.37% compared to head (6516b66) 83.51%.
Report is 4 commits behind head on main.

Files Patch % Lines
xagg/core.py 50.00% 2 Missing ⚠️
xagg/classes.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   82.37%   83.51%   +1.14%     
==========================================
  Files          13       13              
  Lines         885     1092     +207     
==========================================
+ Hits          729      912     +183     
- Misses        156      180      +24     
Flag Coverage Δ
unittests 83.51% <40.00%> (+1.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ks905383 ks905383 merged commit 5d76da9 into main Feb 13, 2024
6 of 9 checks passed
@ks905383 ks905383 deleted the remove_xesmf_req branch February 13, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant