Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tests more robust to dot product implementation #64

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

ks905383
Copy link
Owner

All xa.aggregate() tests now test both the for loop and the dot product implementations

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0075c7e) 82.37% compared to head (2a5d31c) 83.36%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   82.37%   83.36%   +0.99%     
==========================================
  Files          13       13              
  Lines         885     1070     +185     
==========================================
+ Hits          729      892     +163     
- Misses        156      178      +22     
Flag Coverage Δ
unittests 83.36% <100.00%> (+0.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ks905383 ks905383 merged commit 7598237 into main Feb 13, 2024
5 checks passed
@ks905383 ks905383 deleted the update_dotprod_tests branch February 13, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants