Keep ownership of spi::DriverRegistration #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skallwar
approved these changes
May 4, 2021
n1tram1
approved these changes
May 4, 2021
rust-module/mfrc522.rs
Outdated
| spi::DriverRegistration::new(&THIS_MODULE, cstr!("mfrc522")).with_probe(mfrc522_probe); | ||
| spi.register()?; | ||
| spi::DriverRegistration::new_pinned(&THIS_MODULE, cstr!("mfrc522"))? | ||
| .with_probe(mfrc522_probe); |
There was a problem hiding this comment.
can't we just call .register here ?
There was a problem hiding this comment.
Yeah, that's why the FIXME is here for now cause I think it's ugly to do spi.as_mut().register().
We have a solution, which helps with cleanliness: remove the builder pattern (which I agree with) and pass all spi methods in the new_pinned function, and register the driver in the new_pinned function (this is what miscdev.rs does). The downside is that the function takes 3 more arguments, which will be None most of the time
There was a problem hiding this comment.
I'm removing the builder pattern
Skallwar
approved these changes
May 4, 2021
n1tram1
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs ks0n/linux#4.
Closes #41