Merge pull request #16 from ks-labs/refact-different-objects

Refactoring

src/Helpers/DifferentData.js

@@ -0,0 +1,25 @@
+/**
+ * Return only the values ​​that have changed
+ * @param {object} oldData
+ * @param {object} newData
+ * @typedef {object} result
+ */
+module.exports = function differentData(oldData, newData) {
+  let result = { oldData: {}, newData: {} }
+  if (!Object.keys(oldData).length) {
+    result.newData = newData
+  } else {
+    for (let prop in oldData) {
+      if (newData.hasOwnProperty(prop)) {
+        const value1 = oldData[prop]
+        const value2 = newData[prop]
+        if (value1 !== value2) {
+          result.oldData[prop] = value1
+          result.newData[prop] = value2
+        }
+      } else {
+      }
+    }
+  }
+  return result
+}

src/Traits/Auditable.js

@@ -2,31 +2,10 @@
 
 const _ = require('lodash')
 const { AuditableInvalidRelationshipError } = require('../Exceptions')
+const differentData = require('../Helpers/DifferentData')
 /** @type {typeof import('../../templates/Audit')} */
 const Audit = use('App/Models/Audit')
 
-/**
- * Return only the values ​​that have changed
- * @param {*} objectA
- * @param {*} objectB
- * @returns {Object, Object} Object
- */
-
-function differenceObj(objectA, objectB) {
-  let result = { oldValue: {}, newValue: {} }
-  for (let prop in objectA) {
-    if (objectB.hasOwnProperty(prop)) {
-      const value1 = objectA[prop]
-      const value2 = objectB[prop]
-      if (value1 !== value2) {
-        result.oldValue[prop] = value1
-        result.newValue[prop] = value2
-      }
-    }
-  }
-  return result
-}
-
 /**
  * Validates all relations and raise appropiate exceptions when missing
  * this indeed to be used as validation function
@@ -183,9 +162,9 @@ function updateWithAudit(ctx, opts, relationsFn) {
       return persisted
     }
 
-    const { oldValue, newValue } = differenceObj(oldData, newData)
-    oldData = oldValue
-    newData = newValue
+    const difference = differentData(oldData, newData)
+    oldData = difference.oldData
+    newData = difference.newData
 
     // update / patch are shared
     const event = Audit.events.UPDATE