SourceryFramework #715
Merged
SourceryFramework #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll???) and added Yams (how was it even working before???)
Generated by 🚫 Danger |
ilyapuchka
force-pushed
the
sourcery-framework
branch
from
40d2f81
to
2d77f86
Compare
krzysztofzablocki
approved these changes
Dec 26, 2018
|
I've pushed a missing change to the SPM manifest with SourceryFramework.
One solution I see would be to add a Note that the |
|
I've extracted the files into |
|
@ilyapuchka anything left to do here? |
|
@krzysztofzablocki I guess should be fine now with Utils framework |
|
@ilyapuchka you can merge then if you are happy with it 👍 |
This was referenced Mar 6, 2019
Closed
stephanecopin
pushed a commit
to stephanecopin/Sourcery
that referenced
this pull request
Apr 30, 2019
* extract parsing and generating functionality into SourceryFramework * removed unneeded AEXML dependency (have we ever used it directly at all???) and added Yams (how was it even working before???) * removed rangeToAppendBody * Configure SourceryFramework in SPM * Extract Sha, Version and Path+Extensions into SourceryUtils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces SourceryFramework that exposes parsing and generating functionality (generating part is really just two protocols then implemented by the tool). Motivation for that is that this framework can provide the foundation for other tools, especially parsing, which don't necessarily want to use templates and generate code, without the need to include such functionality in the tool. There were multiple requests in the past about such features which were shut down because they were considered out of the scope of Sourcery as a tool.
Mainly this change is about moving files around and changing minimum amount of internal types and properties to public to make the main tool compile. We may want to revisit public API later to expose more things publicly.