feat!(math): improve prime field (de)serialization #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chokobole Please fix c67611f's commit message filed -> field. |
chokobole
force-pushed
the
feat/improve-prime-field-de-serialization
branch
from
6c4f373
to
bcc4a37
Compare
…g json
BREAKING CHANGE: This update simplifies the (de)serialization of prime fields
in JSON. Previously, a prime field was (de)serialized as an object
with a member 'value'. Now, it is (de)serialized directly as a hex string.
For example, the value 3 was previously serialized as `{"value": "0x3"}` and
is now serialized as "0x3".
BREAKING CHANGE: This update changes the (de)serialization of small prime fields in JSON to use numbers instead of hex strings. Given that the modulus of the small prime field is less than `uint32_t`, using JSON numbers is more appropriate. Previously, these values were (de)serialized as hex strings.
BREAKING CHANGE: This update changes the (de)serialization of small prime fields using `base::Copyable` to use `uint32_t` instead of `math::BigInt<N>`. Given that the modulus of the small prime field is less than `uint32_t`, using `uint32_t` is more appropriate. Previously, these values were (de)serialized as `math::BigInt<N>`.
chokobole
force-pushed
the
feat/improve-prime-field-de-serialization
branch
from
bcc4a37
to
f76714d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves prime field (de)serializations in several aspects.