perf!: use icicle msm #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
dongchangYoo,
Insun35,
TomTaehoonKim and
ashjeong
chokobole
force-pushed
the
perf/use-icicle-msm
branch
from
0c236b2
to
06afe6b
Compare
chokobole
force-pushed
the
perf/use-icicle-msm
branch
from
06afe6b
to
c21fb4c
Compare
chokobole
force-pushed
the
perf/use-icicle-msm
branch
from
c21fb4c
to
ecb4904
Compare
chokobole
force-pushed
the
perf/use-icicle-msm
branch
3 times, most recently
from
1937640
to
9fb43f1
Compare
chokobole
force-pushed
the
perf/use-icicle-msm
branch
from
9fb43f1
to
8e09c07
Compare
chokobole
force-pushed
the
perf/use-icicle-msm
branch
from
8e09c07
to
7624e42
Compare
chokobole
force-pushed
the
perf/use-icicle-msm
branch
from
7624e42
to
78e3f13
Compare
ashjeong
requested changes
Jul 3, 2024
tachyon/math/elliptic_curves/msm/algorithms/icicle/icicle_msm.h
Outdated
Show resolved
Hide resolved
|
How about adding GPU benchmark as well? |
GideokKim
reviewed
Jul 3, 2024
One can retrieve `ScalarField` from a template parameter `Point`.
chokobole
force-pushed
the
perf/use-icicle-msm
branch
from
78e3f13
to
bbd293f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates icicle MSM for improved performance!
Previously, the MSM GPU interface accepted input directly from GPU memory, which complicated the use of MSM GPU for the KZG commitment scheme. While we could implement this for previous algorithms, such as Bellman MSM and CUZK, they were slow when dealing with non-random scalar distributions. The advantages of using icicle are twofold: (1) it supports input from CPU memory, and (2) it performs well even with non-random scalar distributions. Consequently, this PR removes the previous implementations and adopts icicle exclusively.