chore(math): add reference for non residue

kroma-network · Jul 20, 2024 · 7bf0339 · 7bf0339
1 parent fcf35e8
commit 7bf0339
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/tachyon/math/finite_fields/baby_bear/internal/BUILD.bazel b/tachyon/math/finite_fields/baby_bear/internal/BUILD.bazel
@@ -10,6 +10,7 @@ generate_fp4s(
     class_name = "BabyBear4",
     is_packed = False,
     namespace = "tachyon::math",
+    # See https://github.com/Plonky3/Plonky3/blob/d9ef3902abcc6a34b75f6820da168460aee26763/baby-bear/src/baby_bear.rs#L80.
     non_residue = ["11"],
     deps = ["//tachyon/math/finite_fields/baby_bear"],
 )
@@ -22,6 +23,7 @@ generate_fp4s(
     class_name = "PackedBabyBear4",
     is_packed = True,
     namespace = "tachyon::math",
+    # See https://github.com/Plonky3/Plonky3/blob/d9ef3902abcc6a34b75f6820da168460aee26763/baby-bear/src/baby_bear.rs#L80.
     non_residue = ["11"],
     deps = ["//tachyon/math/finite_fields/baby_bear:packed_baby_bear"],
 )
diff --git a/tachyon/math/finite_fields/goldilocks/internal/BUILD.bazel b/tachyon/math/finite_fields/goldilocks/internal/BUILD.bazel
@@ -32,6 +32,7 @@ generate_fp2s(
     class_name = "Goldilocks2",
     is_packed = False,
     namespace = "tachyon::math",
+    # See https://github.com/Plonky3/Plonky3/blob/d9ef3902abcc6a34b75f6820da168460aee26763/goldilocks/src/extension.rs#L7-L11.
     non_residue = ["7"],
     deps = [":goldilocks"],
 )

diff --git a/tachyon/math/finite_fields/koala_bear/internal/BUILD.bazel b/tachyon/math/finite_fields/koala_bear/internal/BUILD.bazel
@@ -10,6 +10,7 @@ generate_fp4s(
     class_name = "KoalaBear4",
     is_packed = False,
     namespace = "tachyon::math",
+    # See https://github.com/Plonky3/Plonky3/blob/d9ef3902abcc6a34b75f6820da168460aee26763/koala-bear/src/koala_bear.rs#L80.
     non_residue = ["3"],
     deps = ["//tachyon/math/finite_fields/koala_bear"],
 )
@@ -22,6 +23,7 @@ generate_fp4s(
     class_name = "PackeKoalaBear4",
     is_packed = True,
     namespace = "tachyon::math",
+    # See https://github.com/Plonky3/Plonky3/blob/d9ef3902abcc6a34b75f6820da168460aee26763/koala-bear/src/koala_bear.rs#L80.
     non_residue = ["3"],
     deps = ["//tachyon/math/finite_fields/koala_bear:packed_koala_bear"],
 )